Message332953
Terry,
I just saw your note about waiting to split this into a Window and Frame class, which was after I had already gotten the PR ready. I've been mostly offline for the past few days, so I had been working on those changes locally with the intent of pushing them once I was back online. I understand if it's not a priority to review. My main goal in splitting them was more for readability rather than for being able to add it to a Tabbed window. As a follow up to this refactor, I had hoped to split the Basic and Advanced frames into their own tabs, mostly to clean up the create_widgets and to organize the supporting functions.
Anyway, PR11427 refactors the main frame from the window. |
|
Date |
User |
Action |
Args |
2019-01-04 00:02:03 | cheryl.sabella | set | recipients:
+ cheryl.sabella, terry.reedy, miss-islington |
2019-01-04 00:02:01 | cheryl.sabella | set | messageid: <1546560121.63.0.0811626448106.issue35598@roundup.psfhosted.org> |
2019-01-04 00:02:01 | cheryl.sabella | link | issue35598 messages |
2019-01-04 00:02:01 | cheryl.sabella | create | |
|