This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Michael.Felt
Recipients David.Edelsohn, Michael.Felt, pitrou, serhiy.storchaka
Date 2018-12-28.17:46:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1546019173.19.0.211066908357.issue28009@roundup.psfhosted.org>
In-reply-to
Content
As I am not clear on where to have a more general discussion (in a PR conversation) or here - going to start here because I cannot figure out which comment in the PR to reply to.

Generally, before modifying the test_uuid.py to based tests on uuid.__NODE_GETTERS - these need to be defined.

I have my AIX systems, I found a macos I could do some queries on, and downloaded cygwin and came up with this starting point:

_MACOS = sys.platform == 'darwin'
_WIN32 = sys.platform == 'win32'
_CYGWIN= sys.platform == 'cygwin'
_AIX = sys.platform.startswith("aix")

...

if _AIX:
    _NODE_GETTERS = [_unix_getnode, _netstat_getnode]
elif _MACOS:
    _NODE_GETTERS = [_unix_getnode, _ifconfig_getnode, _netstat_getnode]
elif _CYGWIN:
    _NODE_GETTERS = [_ipconfig_getnode]
elif _WIN32:
    _NODE_GETTERS = [_windll_getnode, _ipconfig_getnode, _netbios_getnode]
else:
    _NODE_GETTERS = [_unix_getnode, _ifconfig_getnode, _ip_getnode,
                          _arp_getnode, _lanscan_getnode, _netstat_getnode]


What I am also wondering - is it worthwhile to have a way to only define the getter() routines a platform can actually use? e.g., On AIX I can call uuid._ipconfig_getter(), but get nonsense. Or is it too much effort?

Finally, can someone with access to other platforms where differences may be expected (e.g., Solaris, hpux, or even different flavors of Linux) - to make this _NODE_GETTERS mode complete (specific).
History
Date User Action Args
2018-12-28 17:46:15Michael.Feltsetrecipients: + Michael.Felt, pitrou, serhiy.storchaka, David.Edelsohn
2018-12-28 17:46:13Michael.Feltsetmessageid: <1546019173.19.0.211066908357.issue28009@roundup.psfhosted.org>
2018-12-28 17:46:13Michael.Feltlinkissue28009 messages
2018-12-28 17:46:13Michael.Feltcreate