Author mariocj89
Recipients Alexander Oblovatniy, azsorkin, cjw296, mariocj89, michael.foord, nekobon, r.david.murray, rbcollins, rhettinger, xtreak
Date 2018-12-21.10:14:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
I would suggest applying the fix with the latest version in mind to keep the codebase clean. If you want to backport it to previous versions of Python you can do it manually through a PR targetting the right branch.
I think the process is to set up a label and then use as I'd expect the tests to fail to apply the patch "manually.

Alternative 1: Might be easier is to send a patch that works in all version and another one that "modernises" it to python3.7. Basically, write all tests with OrderedDict and then just shoot an extra PR that converts that to a plain dict.

Alternative 2: This is only a problem on versions on versions < 3.6, isn't it? If so you might want to close this issue or just have a PR that targets the 3.5 if worth backporting and/or PyPI's. (This is my conservative mind as you know I usually push for changing as less as possible hehe).
Date User Action Args
2018-12-21 10:14:38mariocj89setrecipients: + mariocj89, rhettinger, rbcollins, cjw296, r.david.murray, michael.foord, nekobon, azsorkin, Alexander Oblovatniy, xtreak
2018-12-21 10:14:38mariocj89setmessageid: <>
2018-12-21 10:14:38mariocj89linkissue24928 messages
2018-12-21 10:14:38mariocj89create