Message332018
Actually, in my implementation, it also supports POLL with the different event.
I don't think to make selector be a public property is a good idea. It will break the whole system integrity.
Please think about it, if people want to use epoll/poll with some special event, they must use it like this.
> s = selectors.EpollSelector()
> s.selector.register(fd,select.EPOLLIN | select.EPOLLEXCLUSIVE)
> s.selector.modify(fd,select.EPOLLOU | select.EPOLLEXCLUSIVE)
Here's a question, why we support the register?
I think it will make people don't care about the detail.
So, as you say, it's a little bit complicated, but it will help people don't care about the selector property detail, they just use the argument when they want to use it.
I think it's worth it. |
|
Date |
User |
Action |
Args |
2018-12-17 19:06:17 | Manjusaka | set | recipients:
+ Manjusaka, gvanrossum, vstinner, giampaolo.rodola, asvetlov, neologix, yselivanov |
2018-12-17 19:06:17 | Manjusaka | set | messageid: <1545073577.04.0.788709270274.issue35517@psf.upfronthosting.co.za> |
2018-12-17 19:06:17 | Manjusaka | link | issue35517 messages |
2018-12-17 19:06:16 | Manjusaka | create | |
|