Author vstinner
Recipients Manjusaka, giampaolo.rodola, neologix, vstinner, yselivanov
Date 2018-12-17.11:47:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1545047231.19.0.788709270274.issue35517@psf.upfronthosting.co.za>
In-reply-to
Content
I prefer Giampaolo since discussed flags are very specific to epoll(): select() doesn't support them for example, nor kqueue nor devpoll (not *yet*).

If we add a keyword-parameter, to me, it sounds like it's something "portable" working on multiple platforms and then you need hasattr():

                if exclusive and hasattr(select, "EPOLLEXCLUSIVE"):
                    epoll_events |= select.EPOLLEXCLUSIVE

If the caller pass select.EPOLLEXCLUSIVE, hasattr() is useless.

Moreover, we directly support any EPOLL constant exposed in the select module. No need to change the API.
History
Date User Action Args
2018-12-17 11:47:11vstinnersetrecipients: + vstinner, giampaolo.rodola, neologix, yselivanov, Manjusaka
2018-12-17 11:47:11vstinnersetmessageid: <1545047231.19.0.788709270274.issue35517@psf.upfronthosting.co.za>
2018-12-17 11:47:11vstinnerlinkissue35517 messages
2018-12-17 11:47:11vstinnercreate