Author mariocj89
Recipients cjw296, mariocj89, michael.foord, xtreak
Date 2018-12-15.22:27:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1544912849.62.0.788709270274.issue35500@psf.upfronthosting.co.za>
In-reply-to
Content
Makes sense!

I'd not align them though but that might be my view as I generally don't like aligning text like that.

Also if you feel that the exceptions read "weird" with the first sentence is empty, an option might be to say the calls don't match, to make it symmetric with the assert_calls message. Example:


Traceback (most recent call last):
  File "/tmp/bar.py", line 5, in <module>
    m.assert_called_with(2, 3)
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/mock.py", line 827, in assert_called_with
    raise AssertionError(_error_message()) from cause
AssertionError: Expected call not found.
Expected call: mock(2, 3)
Actual call: mock(1, 2)

This way all error reports give you the issue in the first line of the message and further details in the next lines.
History
Date User Action Args
2018-12-15 22:27:29mariocj89setrecipients: + mariocj89, cjw296, michael.foord, xtreak
2018-12-15 22:27:29mariocj89setmessageid: <1544912849.62.0.788709270274.issue35500@psf.upfronthosting.co.za>
2018-12-15 22:27:29mariocj89linkissue35500 messages
2018-12-15 22:27:29mariocj89create