Message 331465 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	PashaWNN
Recipients	PashaWNN, martin.panter
Date	2018-12-10.04:17:07
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1544415427.54.0.788709270274.issue35447@psf.upfronthosting.co.za>
In-reply-to

Content
https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L875 It's redundant to raise and then catch exception. I mean: if len(query) and not isinstance(query[0], tuple): ty, va, tb = sys.exc_info() raise TypeError("not a valid non-string sequence " "or mapping object").with_traceback(tb) Would be more clean.

https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L875
It's redundant to raise and then catch exception.

I mean:
if len(query) and not isinstance(query[0], tuple):
    ty, va, tb = sys.exc_info()
    raise TypeError("not a valid non-string sequence "
                    "or mapping object").with_traceback(tb)


Would be more clean.

History
Date	User	Action	Args
2018-12-10 04:17:07	PashaWNN	set	recipients: + PashaWNN, martin.panter
2018-12-10 04:17:07	PashaWNN	set	messageid: <1544415427.54.0.788709270274.issue35447@psf.upfronthosting.co.za>
2018-12-10 04:17:07	PashaWNN	link	issue35447 messages
2018-12-10 04:17:07	PashaWNN	create