Author vstinner
Recipients Windson Yang, benjamin.peterson, davin, docs@python, mattip, ned.deily, pablogsal, pitrou, tzickel, vstinner, zach.ware
Date 2018-12-03.23:07:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1543878478.86.0.788709270274.issue34172@psf.upfronthosting.co.za>
In-reply-to
Content
> I found the weird code in the example in several projects. I have corrected it to use the pool as a context manager or to call close(), but this means that users are doing this and it used to work and not it does not: technically is a regression.

That's why I'm asking for a revert :-) I suggest to revert this change immediately from 2.7, 3.6 and 3.7, and later see what can be done for master.

Even if we design carefully an API, there will be always someone to misuse it :-) I would prefer to stop promoting such bad code and find a transition to more correct code.

I disagree that a child should keep its parent alive.

I would be ok to use a *weak reference* from the child to the parent to detect when the parent goes away, and maybe trigger an action in that case. For example, raise an exception or log a warning.
History
Date User Action Args
2018-12-03 23:07:58vstinnersetrecipients: + vstinner, pitrou, benjamin.peterson, ned.deily, docs@python, zach.ware, mattip, davin, tzickel, pablogsal, Windson Yang
2018-12-03 23:07:58vstinnersetmessageid: <1543878478.86.0.788709270274.issue34172@psf.upfronthosting.co.za>
2018-12-03 23:07:58vstinnerlinkissue34172 messages
2018-12-03 23:07:58vstinnercreate