This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients serhiy.storchaka, vstinner
Date 2018-12-03.11:13:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1543835639.16.0.788709270274.issue35373@psf.upfronthosting.co.za>
In-reply-to
Content
Hum. By the way, PyInit_time() calls PyModule_AddObject() without checking for errors :-/

PyMODINIT_FUNC
PyInit_time(void)
{
    PyObject *m;
    m = PyModule_Create(&timemodule);
    if (m == NULL)
        return NULL;
    ...
    PyModule_AddObject(m, "struct_time", (PyObject*) &StructTimeType);
    ...
    return m;
}

It should have at least one final generic:

    if (PyErr_Occurred()) {
        return -1;
    }
History
Date User Action Args
2018-12-03 11:13:59vstinnersetrecipients: + vstinner, serhiy.storchaka
2018-12-03 11:13:59vstinnersetmessageid: <1543835639.16.0.788709270274.issue35373@psf.upfronthosting.co.za>
2018-12-03 11:13:59vstinnerlinkissue35373 messages
2018-12-03 11:13:59vstinnercreate