Author rhettinger
Recipients Mariatta, dfrojas, eli.bendersky, nedbat, rhettinger, scoder, serhiy.storchaka, taleinat, vstinner
Date 2018-11-16.19:12:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1542395569.63.0.788709270274.issue34160@psf.upfronthosting.co.za>
In-reply-to
Content
> I run my test suite on 2.7, 3.4, 3.5, 3.6, 3.7, 3.8, PyPy2, 
> and PyPy3.  Today, one gold file suffices for all those
> versions.  Without the sorted attributes, 3.8 fails the test.

Would it make sense to rewrite the test to just make sure the XML roundtrips instead of relying on the exact byte sequence that is generated?  IIRC, that is how we test pickling and various codecs -- rather than relying on implement specific details for a particular byte sequence -- the test is roughly "assert decode(encode(thing)) == thing".  That allows the test to survive on-going improvements to serialization.
History
Date User Action Args
2018-11-16 19:12:49rhettingersetrecipients: + rhettinger, scoder, vstinner, taleinat, nedbat, eli.bendersky, serhiy.storchaka, Mariatta, dfrojas
2018-11-16 19:12:49rhettingersetmessageid: <1542395569.63.0.788709270274.issue34160@psf.upfronthosting.co.za>
2018-11-16 19:12:49rhettingerlinkissue34160 messages
2018-11-16 19:12:49rhettingercreate