Author eamanu
Recipients Ankur.Ankan, Chris AtLee, Elena.Oat, Eric Lafontaine, Jacek.Bzdak, Puneeth.Chaganti, ankurankan, eamanu, ezio.melotti, gregory.p.smith, levkivskyi, michael.foord, nnja, paul.moore, pitrou, rbcollins, serhiy.storchaka, steve.dower, tim.golden, vstinner, xtreak, zach.ware
Date 2018-11-11.01:26:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1541899614.94.0.788709270274.issue19217@psf.upfronthosting.co.za>
In-reply-to
Content
Hi!

I see that this issue have a pr (https://github.com/python/cpython/pull/10034) opened 20 days ago. So, I want to continue work on this (my first pr).

I use the vstinner's patch and I make two little change (attached patch):

1) first I add the "expected" and "got" mentioned by vstinner. 
2) I quit the @@ -1 +1 @@ in case of the input are list or tuple, because IMO this does not give me lot of information (and could be confuse, because I can interpret that the lists differ on the first element)

This is the output for the vstinner test case. 

What do you think?
History
Date User Action Args
2018-11-11 01:26:55eamanusetrecipients: + eamanu, gregory.p.smith, paul.moore, pitrou, vstinner, rbcollins, tim.golden, ezio.melotti, michael.foord, zach.ware, serhiy.storchaka, Jacek.Bzdak, steve.dower, Ankur.Ankan, Elena.Oat, nnja, ankurankan, Puneeth.Chaganti, levkivskyi, Chris AtLee, Eric Lafontaine, xtreak
2018-11-11 01:26:54eamanusetmessageid: <1541899614.94.0.788709270274.issue19217@psf.upfronthosting.co.za>
2018-11-11 01:26:54eamanulinkissue19217 messages
2018-11-11 01:26:53eamanucreate