Message329572
Thanks. I don't really know enough about compilers and required-vs-optional C99 semantics to know whether these changes are safe. These are very old APIs and are used throughout the entire Python ecosystem. It would pay to be somewhat cautious.
The whole C-API project is predicated on giving a 2x speed-up in exchange for destabilizing changes. These cross-module inline function-for-macro swaps aren't aligned with that goal. At the very best, the swaps will be performance neutral. At worst, they will invisibly degrade a huge swath of code, someone of which is finely-tuned (people generally only use PyTuple_GET_ITEM() in places where they want better performance than the existing function based alternative) |
|
Date |
User |
Action |
Args |
2018-11-10 00:10:36 | rhettinger | set | recipients:
+ rhettinger, vstinner |
2018-11-10 00:10:36 | rhettinger | set | messageid: <1541808636.73.0.788709270274.issue35199@psf.upfronthosting.co.za> |
2018-11-10 00:10:36 | rhettinger | link | issue35199 messages |
2018-11-10 00:10:36 | rhettinger | create | |
|