Author vstinner
Recipients akeskimo, vstinner
Date 2018-11-08.12:53:42
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1541681622.96.0.788709270274.issue35189@psf.upfronthosting.co.za>
In-reply-to
Content
> https://github.com/nierob/cpython/commit/3b76b887b2b339664dc52c5f246bc7cb268ea616

Oh, nice! Please rebase this change on the master branch and reuse "int async_err = 0;" pattern from Modules/posixmodule.c. You must not raise a new exception if PyErr_CheckSignals() raised an exception, something like:

        return (!async_err) ? posix_error() : NULL;
History
Date User Action Args
2018-11-08 12:53:42vstinnersetrecipients: + vstinner, akeskimo
2018-11-08 12:53:42vstinnersetmessageid: <1541681622.96.0.788709270274.issue35189@psf.upfronthosting.co.za>
2018-11-08 12:53:42vstinnerlinkissue35189 messages
2018-11-08 12:53:42vstinnercreate