➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients eric.snow, vstinner
Date 2018-11-01.01:31:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1541035882.25.0.788709270274.issue35081@psf.upfronthosting.co.za>
In-reply-to
Content 
Copy of my comment on PR 10271:
https://github.com/python/cpython/pull/10271#issuecomment-434897408

I tried to enforce to require Py_BUILD_CORE in pycore_accu.h to be defined using:

#ifndef Py_BUILD_CORE
#  error "Py_BUILD_CORE must be defined to include this header"
#endif

But the compilation of the _json module failed, because it isn't compiled with Py_BUILD_CORE. Moreover, _json.c contains:

/* Core extension modules are built-in on some platforms (e.g. Windows). */
#ifdef Py_BUILD_CORE
#define Py_BUILD_CORE_BUILTIN
#undef Py_BUILD_CORE
#endif
History
Date User Action Args
2018-11-01 01:31:22vstinnersetrecipients: + vstinner, eric.snow
2018-11-01 01:31:22vstinnersetmessageid: <1541035882.25.0.788709270274.issue35081@psf.upfronthosting.co.za>
2018-11-01 01:31:22vstinnerlinkissue35081 messages
2018-11-01 01:31:21vstinnercreate