Message327870
I carefully read both the two PRs. The first one, easy to understand. The second one, I spend some time to figure out why the test doesn't crash, why we need to have reference count checks in two places and make some experiments to test in different cases, how the reference counts will be. I am afraid I have to repeat this procedure after some time when reading the code again. :-( And while in some cases the second approach increases performance. But in others cases it might hurt. Codes storing the array in a variable will go into the iterator branch. |
|
Date |
User |
Action |
Args |
2018-10-17 08:25:40 | xiang.zhang | set | recipients:
+ xiang.zhang, alexandre.vassalotti, serhiy.storchaka |
2018-10-17 08:25:40 | xiang.zhang | set | messageid: <1539764740.29.0.788709270274.issue34973@psf.upfronthosting.co.za> |
2018-10-17 08:25:40 | xiang.zhang | link | issue34973 messages |
2018-10-17 08:25:40 | xiang.zhang | create | |
|