Author josh.r
Recipients aecant, josh.r, serhiy.storchaka
Date 2018-10-03.19:52:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1538596375.65.0.545547206417.issue34886@psf.upfronthosting.co.za>
In-reply-to
Content
The actual code receives input by name, but stdin is received in **kwargs. The test is just:

    if input is not None:
        if 'stdin' in kwargs:
            raise ValueError(...)
        kwargs['stdin'] = PIPE

Perhaps just change `if 'stdin' in kwargs:` to:

    if kwargs.get('stdin') is not None:

so it obeys the documented API (that says stdin defaults to None, and therefore passing stdin=None explicitly should be equivalent to not passing it at all)?
History
Date User Action Args
2018-10-03 19:52:55josh.rsetrecipients: + josh.r, serhiy.storchaka, aecant
2018-10-03 19:52:55josh.rsetmessageid: <1538596375.65.0.545547206417.issue34886@psf.upfronthosting.co.za>
2018-10-03 19:52:55josh.rlinkissue34886 messages
2018-10-03 19:52:55josh.rcreate