Author nascheme
Recipients benjamin.peterson, brett.cannon, gvanrossum, nascheme, ncoghlan, serhiy.storchaka, thautwarm, vstinner, yselivanov
Date 2018-10-03.16:19:07
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1538583547.9.0.545547206417.issue34822@psf.upfronthosting.co.za>
In-reply-to
Content
Hello Serhiy,

I've not reviewed the patch but I trust that if you say it simplifies things, that's so.  Perhaps the important question is if it is okay to change the AST in backwards incompatible ways within 3.x releases.  As a library author who could be affected, I think it is okay. The AST is mostly an implementation detail and should not required to maintain compatibility.  We expose it via the 'ast' module for low level tools that want to manipulate it.  It is up to those users to handle backwards incompatible changes.

That said, we shouldn't just change it for trivial reasons.  That just causes work for 3rd party libraries.  Removing 400 lines of code seems like sufficient reason.
History
Date User Action Args
2018-10-03 16:19:08naschemesetrecipients: + nascheme, gvanrossum, brett.cannon, ncoghlan, vstinner, benjamin.peterson, serhiy.storchaka, yselivanov, thautwarm
2018-10-03 16:19:07naschemesetmessageid: <1538583547.9.0.545547206417.issue34822@psf.upfronthosting.co.za>
2018-10-03 16:19:07naschemelinkissue34822 messages
2018-10-03 16:19:07naschemecreate