Author steve.dower
Recipients eryksun, giampaolo.rodola, jopamer, paul.moore, steve.dower, terry.reedy, tim.golden, zach.ware
Date 2018-09-18.04:13:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1537244000.47.0.956365154283.issue32557@psf.upfronthosting.co.za>
In-reply-to
Content
I took a quick look at the patch and the main issue I see is the use of the MAX_PATH constant. We encourage people to disable this limit where possible, so using dynamic allocation where we need to reduce the path will be a better way to avoid this function breaking.

There should be other examples of this pattern in the file, but I don't think it'll matter here if we always copy the string. Better to avoid it, of course, but that complicates things.
History
Date User Action Args
2018-09-18 04:13:20steve.dowersetrecipients: + steve.dower, terry.reedy, paul.moore, giampaolo.rodola, tim.golden, zach.ware, eryksun, jopamer
2018-09-18 04:13:20steve.dowersetmessageid: <1537244000.47.0.956365154283.issue32557@psf.upfronthosting.co.za>
2018-09-18 04:13:20steve.dowerlinkissue32557 messages
2018-09-18 04:13:20steve.dowercreate