Author Jeffrey.Walton
Recipients Jeffrey.Walton, alex, alexandre.vassalotti, deadshort, dmalcolm, donmez, fweimer, jcea, jwilk, loewis, mark.dickinson, martin.panter, matejcik, miss-islington, nnorwitz, pitrou, python-dev, serhiy.storchaka, vstinner, xiang.zhang, ztane
Date 2018-09-12.00:53:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH8yC8n4eALjVon0VxHLV+y5hoqnLr+ohsMSCeHkVPZcoFXSpQ@mail.gmail.com>
In-reply-to <1536711982.01.0.0269046726804.issue1621@psf.upfronthosting.co.za>
Content
On Tue, Sep 11, 2018 at 8:26 PM, STINNER Victor <report@bugs.python.org> wrote:
>
> STINNER Victor <vstinner@redhat.com> added the comment:
>
>> newsize <<= 1; // The largest possible value is PY_SSIZE_T_MAX + 1.
>
> Previously, there was a explicitly check for error raising  PyErr_NoMemory() on overflow. Now you rely on PyMem_Malloc() to detect the overflow. I'm not sure that it's a good idea.

+1. It will probably work as expected on Solaris and other OSes that
don't oversubscribe memory. It will probably fail in unexpected ways
on Linux when the allocation succeeds but then the OOM killer hits a
random process.

Jeff
History
Date User Action Args
2018-09-12 00:53:35Jeffrey.Waltonsetrecipients: + Jeffrey.Walton, loewis, nnorwitz, jcea, mark.dickinson, pitrou, vstinner, alexandre.vassalotti, donmez, matejcik, jwilk, alex, dmalcolm, python-dev, deadshort, martin.panter, serhiy.storchaka, ztane, fweimer, xiang.zhang, miss-islington
2018-09-12 00:53:34Jeffrey.Waltonlinkissue1621 messages
2018-09-12 00:53:34Jeffrey.Waltoncreate