Author gregory.p.smith
Recipients benjamin.peterson, gregory.p.smith, izbyshev, pitrou, stutzbach, vstinner
Date 2018-09-10.23:56:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1536623775.62.0.0269046726804.issue32236@psf.upfronthosting.co.za>
In-reply-to
Content
My problem with a warning is the standard one: People who see a warning are often end users of python applications (who don't even have to know what Python is, let alone know anything about the code).  For that reason, never add a warning to a stable branch - only new releases (meaning 3.8 here).

Given that this isn't not a deprecation of meaningful API behavior but is highlighting questionably undefined nonsense behavior, users complaining upon obtaining 3.8 should ultimately reach library and application developers who use the API wrong to update their call sites to explicitly ask for what they intended instead of being ambiguious.

FYI - the subprocess.py related changes in your PR are correct.
History
Date User Action Args
2018-09-10 23:56:15gregory.p.smithsetrecipients: + gregory.p.smith, pitrou, vstinner, benjamin.peterson, stutzbach, izbyshev
2018-09-10 23:56:15gregory.p.smithsetmessageid: <1536623775.62.0.0269046726804.issue32236@psf.upfronthosting.co.za>
2018-09-10 23:56:15gregory.p.smithlinkissue32236 messages
2018-09-10 23:56:15gregory.p.smithcreate