Message324641
The real question isn't "are we on Windows?" but rather "should we use msvcrt/_winapi or _posixsubprocess/select?", which is what my PR is designed to better fit. I could see how we wouldn't want to backport that patch to maintenance branches, though; it's a significant rearrangement. If we do want to backport *a* fix, I agree that simply adding `or os.name == 'nt'` should be sufficiently low-impact. |
|
Date |
User |
Action |
Args |
2018-09-05 14:53:03 | zach.ware | set | recipients:
+ zach.ware, gregory.p.smith, amaury.forgeotdarc, pitrou, vstinner, giampaolo.rodola, dino.viehland, r.david.murray, midnightdf, Jim.Jewett |
2018-09-05 14:53:03 | zach.ware | set | messageid: <1536159183.8.0.56676864532.issue8110@psf.upfronthosting.co.za> |
2018-09-05 14:53:03 | zach.ware | link | issue8110 messages |
2018-09-05 14:53:03 | zach.ware | create | |
|