➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ronaldoussoren
Recipients eelizondo, ronaldoussoren
Date 2018-08-28.19:29:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1535484585.06.0.56676864532.issue34522@psf.upfronthosting.co.za>
In-reply-to
Content 
I don't agree with "This means that a PyTypeObject's ob_type should always be set by PyType_Ready.", and therefore don't agree with the change to PyVarObject_HEAD_INIT.

In particular this is not correct when the type has a custom metatype (e.g. ob_type != &PyType_Type). 

BTW. I don't understand why changing the invocation of PyVarObject_HEAD_INIT is needed at all.  Adding calls to PyType_Ready can be don without that change (and I agree with explicitly initialising all types).
History
Date User Action Args
2018-08-28 19:29:45ronaldoussorensetrecipients: + ronaldoussoren, eelizondo
2018-08-28 19:29:45ronaldoussorensetmessageid: <1535484585.06.0.56676864532.issue34522@psf.upfronthosting.co.za>
2018-08-28 19:29:45ronaldoussorenlinkissue34522 messages
2018-08-28 19:29:44ronaldoussorencreate