Author izbyshev
Recipients belopolsky, izbyshev, p-ganssle, serhiy.storchaka
Date 2018-08-21.22:34:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1534890872.31.0.56676864532.issue34454@psf.upfronthosting.co.za>
In-reply-to
Content
I will be glad to rebase my PR and remove the try/except from the test if you remove the dependency of separator searching code on PyUnicode_AsUTF8AndSize() as you suggest. Or we can go the other way and merge mine first -- whatever you prefer.

Note that technically a difference between C and Python implementation of fromisoformat() will still remain: if a part of the input string before or after the separator contains surrogates, the C code will throw a UnicodeEncodeError while the Python code -- ValueError. But since the former error is a subclass of the latter, I guess it's OK, what do you think?

Also, note that the other discovered C/Python impl difference (for strftime, handled by another try/catch in tests) won't go away, of course, unless someone is ready to fix that as well.
History
Date User Action Args
2018-08-21 22:34:32izbyshevsetrecipients: + izbyshev, belopolsky, serhiy.storchaka, p-ganssle
2018-08-21 22:34:32izbyshevsetmessageid: <1534890872.31.0.56676864532.issue34454@psf.upfronthosting.co.za>
2018-08-21 22:34:32izbyshevlinkissue34454 messages
2018-08-21 22:34:32izbyshevcreate