Message323340
I'm not too invested in any changes happening at this point, actually. :) Mostly I happened to be reading through the commit and noticed the inconsistency. If I had reviewed the PR then I would have asked that it be fixed. So I figured I'd mention it.
FWIW, I don't expect it would cause any problems. It could result in a different (between the two implementations) Task repr if the name's type (a str subclass) implements __repr__. There's also the possibility of side-effects (from the implementation of the name's type). Neither is a big deal (especially the latter since it's *not* a common use case). On the other had, the matter is made moot by using PyUnicode_CheckExact(). :) |
|
Date |
User |
Action |
Args |
2018-08-09 15:39:36 | eric.snow | set | recipients:
+ eric.snow, asvetlov, alex.gronholm, yselivanov |
2018-08-09 15:39:36 | eric.snow | set | messageid: <1533829176.37.0.56676864532.issue34270@psf.upfronthosting.co.za> |
2018-08-09 15:39:36 | eric.snow | link | issue34270 messages |
2018-08-09 15:39:36 | eric.snow | create | |
|