This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author yselivanov
Recipients alex.gronholm, asvetlov, eric.snow, yselivanov
Date 2018-08-09.15:16:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1533827815.86.0.56676864532.issue34270@psf.upfronthosting.co.za>
In-reply-to
Content
> Ok, I understand. But is the conversion a bad thing then?

It's not a bad thing, it's just that we don't do it in C Task and we do it in pure Python Task.  Eric wants us to synchronize them so that in a very unlikely scenario where someone uses subclasses of str for names they will have exact same behaviour under both Tasks implementations.

I'd say let's just fix the C version to use PyUnicode_CheckExact.  Even though it's highly unlikely somebody ever hits this, there's no reason to keep Python and C implementations even slightly out of sync w.r.t. behaviour.
History
Date User Action Args
2018-08-09 15:16:55yselivanovsetrecipients: + yselivanov, asvetlov, alex.gronholm, eric.snow
2018-08-09 15:16:55yselivanovsetmessageid: <1533827815.86.0.56676864532.issue34270@psf.upfronthosting.co.za>
2018-08-09 15:16:55yselivanovlinkissue34270 messages
2018-08-09 15:16:55yselivanovcreate