Author giampaolo.rodola
Recipients benhoyt, benjamin.peterson, brett.cannon, giampaolo.rodola, ncoghlan, serhiy.storchaka, stutzbach, tarek, vstinner, yselivanov
Date 2018-08-02.00:16:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1533168991.89.0.56676864532.issue33695@psf.upfronthosting.co.za>
In-reply-to
Content
I agree the provided benchmark on Linux should be more refined. And I'm not sure if "echo 3 | sudo tee /proc/sys/vm/drop_caches" before running it is enough honestly.

The main point here is the reduction of stat() syscalls (-38%) and that can make a considerable  difference, especially with network filesystems. That's basically the reason why scandir() was introduced in the first place and used in os.walk() glob.glob() and shutil.rmtree(), so I'm not sure why we should use a different rationale for shutil.copytree().
History
Date User Action Args
2018-08-02 00:16:32giampaolo.rodolasetrecipients: + giampaolo.rodola, brett.cannon, ncoghlan, vstinner, benjamin.peterson, tarek, stutzbach, benhoyt, serhiy.storchaka, yselivanov
2018-08-02 00:16:31giampaolo.rodolasetmessageid: <1533168991.89.0.56676864532.issue33695@psf.upfronthosting.co.za>
2018-08-02 00:16:31giampaolo.rodolalinkissue33695 messages
2018-08-02 00:16:30giampaolo.rodolacreate