Author serhiy.storchaka
Recipients benhoyt, benjamin.peterson, brett.cannon, giampaolo.rodola, ncoghlan, serhiy.storchaka, stutzbach, tarek, vstinner, yselivanov
Date 2018-08-01.16:20:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1533140444.07.0.56676864532.issue33695@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not convinced that this change should be merged. The benefit is small, and 1) it is only for an artificial set of tiny files, 2) the benchmarking ignores the real IO, it measures the work with a cache. When copy real files (/usr/include or Lib/) with dropped caches the difference is insignificant. On other hand, this optimization makes the code more complex. It can make the case with specifying the ignore argument slower.
History
Date User Action Args
2018-08-01 16:20:44serhiy.storchakasetrecipients: + serhiy.storchaka, brett.cannon, ncoghlan, vstinner, giampaolo.rodola, benjamin.peterson, tarek, stutzbach, benhoyt, yselivanov
2018-08-01 16:20:44serhiy.storchakasetmessageid: <1533140444.07.0.56676864532.issue33695@psf.upfronthosting.co.za>
2018-08-01 16:20:44serhiy.storchakalinkissue33695 messages
2018-08-01 16:20:44serhiy.storchakacreate