Message321849
Hey, I saw the issue and spent some time piecing together a PR for it. I've never contributed to Python before but this seemed like a good place to start!
I posted these questions on the PR but I'll echo them here as well.
- Should we only handle the specific exceptions that are created in these two examples? or is there a cleaner, more pythonic way to handle it?
- It doesn't appear that test_sndhdr.py does any testing of bad inputs. Can I add test cases to the test_sndhdr.py file?
Thanks! I'm here to learn so if there's anything I missed please feel free to let me know. |
|
Date |
User |
Action |
Args |
2018-07-17 18:18:03 | davidawad | set | recipients:
+ davidawad, vstinner, ammar2, lys.nikolaou, Barro |
2018-07-17 18:18:03 | davidawad | set | messageid: <1531851483.74.0.56676864532.issue34088@psf.upfronthosting.co.za> |
2018-07-17 18:18:03 | davidawad | link | issue34088 messages |
2018-07-17 18:18:03 | davidawad | create | |
|