This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author davidawad
Recipients Barro, ammar2, davidawad, lys.nikolaou, vstinner
Date 2018-07-17.18:18:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1531851483.74.0.56676864532.issue34088@psf.upfronthosting.co.za>
In-reply-to
Content
Hey, I saw the issue and spent some time piecing together a PR for it. I've never contributed to Python before but this seemed like a good place to start!  

I posted these questions on the PR but I'll echo them here as well.

- Should we only handle the specific exceptions that are created in these two examples? or is there a cleaner, more pythonic way to handle it?

- It doesn't appear that test_sndhdr.py does any testing of bad inputs. Can I add test cases to the test_sndhdr.py file?

Thanks! I'm here to learn so if there's anything I missed please feel free to let me know.
History
Date User Action Args
2018-07-17 18:18:03davidawadsetrecipients: + davidawad, vstinner, ammar2, lys.nikolaou, Barro
2018-07-17 18:18:03davidawadsetmessageid: <1531851483.74.0.56676864532.issue34088@psf.upfronthosting.co.za>
2018-07-17 18:18:03davidawadlinkissue34088 messages
2018-07-17 18:18:03davidawadcreate