Author gvanrossum
Recipients asvetlov, gvanrossum, vstinner, yselivanov
Date 2018-07-11.14:53:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAP7+vJKm4TgPF1upo4URx_QD8Hz+SyHU42kSpMehSTEDcTdVHQ@mail.gmail.com>
In-reply-to <1531319684.46.0.56676864532.issue34075@psf.upfronthosting.co.za>
Content
I disagree. Other than subclasses of thread executor, what are you going to
pass in? A mock?

On Wed, Jul 11, 2018 at 7:34 AM STINNER Victor <report@bugs.python.org>
wrote:

>
> STINNER Victor <vstinner@redhat.com> added the comment:
>
> > I think we'll only allow instances of c.f.ThreadPoolExecutor (and its
> subclasses) to be passed to set_default_executor.  That's a more robust
> check than just guarding against ProcessPoolExecutor.
>
> I suggest to only reject ProcessPoolExecutor, instead of having a very
> specific test on ThreadPoolExecutor which might fail with funky but valid
> thread executor.
>
> ----------
> nosy: +vstinner
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <https://bugs.python.org/issue34075>
> _______________________________________
>
-- 
--Guido (mobile)
History
Date User Action Args
2018-07-11 14:53:02gvanrossumsetrecipients: + gvanrossum, vstinner, asvetlov, yselivanov
2018-07-11 14:53:02gvanrossumlinkissue34075 messages
2018-07-11 14:53:02gvanrossumcreate