Author zach.ware
Recipients brett.cannon, chris.jerdonek, ezio.melotti, martin.panter, serhiy.storchaka, zach.ware
Date 2018-07-05.04:07:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1530763622.18.0.56676864532.issue16968@psf.upfronthosting.co.za>
In-reply-to
Content
Looking at this again after 5 years, things have changed a bit and I also better understand what's actually going on in the tests.  IIUC, the `test_main` function's only real purpose was to cause any dangling threads or processes to be reaped, which should actually be done by the shutdown methods of the tested executors.  Doing that cleanup in test_main (if successful), would actually prevent us from getting useful warnings from regrtest if shutdown did not clean up properly, so the attached PR simply removes test_main.
History
Date User Action Args
2018-07-05 04:07:02zach.waresetrecipients: + zach.ware, brett.cannon, ezio.melotti, chris.jerdonek, martin.panter, serhiy.storchaka
2018-07-05 04:07:02zach.waresetmessageid: <1530763622.18.0.56676864532.issue16968@psf.upfronthosting.co.za>
2018-07-05 04:07:02zach.warelinkissue16968 messages
2018-07-05 04:07:01zach.warecreate