Author vstinner
Recipients hajoscher, inada.naoki, vstinner
Date 2018-07-04.08:28:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1530692939.01.0.56676864532.issue34010@psf.upfronthosting.co.za>
In-reply-to
Content
https://github.com/python/cpython/pull/8020/files/77a54a39aace1a38794884218abe801b85b54e62#diff-ef64d8b610dda67977a63a9837f46349

-            buf = "".join(t)
+            buf = b"".join(t)


@hajoscher: "It never caused a problem, since this line is never called; size is never None in the function call. But still, should be fixed, I guess."

Would it be possible to have an unit test for this modified line? Untested code is broken, as you showed :-)
History
Date User Action Args
2018-07-04 08:28:59vstinnersetrecipients: + vstinner, inada.naoki, hajoscher
2018-07-04 08:28:59vstinnersetmessageid: <1530692939.01.0.56676864532.issue34010@psf.upfronthosting.co.za>
2018-07-04 08:28:58vstinnerlinkissue34010 messages
2018-07-04 08:28:58vstinnercreate