This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author orivej
Recipients LnL7, ned.deily, orivej, ronaldoussoren
Date 2018-07-03.02:50:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1530586215.13.0.56676864532.issue34027@psf.upfronthosting.co.za>
In-reply-to
Content
I understand the desirability of avoiding potential problems on supported platforms (given that you can not test building Python on all of them) and recognize that both options you have given are reasonable, but as I see it posixmodule.c incorrectly uses autoconf checks for the presence of header files to infer the platform: it assumes that libutil.h can not exist on macOS. It should either include all found relevant headers, as proposed in my patch or done e.g. in dropbear [1] and gnulib [2], or it should dispatch on the platform directly as LnL7 has proposed (although in this case it should no longer use the autoconf check on macOS).

[1] https://secure.ucc.asn.au/hg/dropbear/file/DROPBEAR_2018.76/includes.h
[2] http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/pty.in.h?id=281b825eba78dc403b9bf34979923bc587bc31af
History
Date User Action Args
2018-07-03 02:50:15orivejsetrecipients: + orivej, ronaldoussoren, ned.deily, LnL7
2018-07-03 02:50:15orivejsetmessageid: <1530586215.13.0.56676864532.issue34027@psf.upfronthosting.co.za>
2018-07-03 02:50:15orivejlinkissue34027 messages
2018-07-03 02:50:14orivejcreate