Author nascheme
Recipients Ilya.Kulakov, nascheme, r.david.murray, steve.dower, tnmurphy, vstinner
Date 2018-06-28.19:18:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1530213521.24.0.56676864532.issue24575@psf.upfronthosting.co.za>
In-reply-to
Content
I ran into an error like this and perhaps I have a clue was why some people run into it.  Dynamic modules built from Modules/Setup will need to have  -DPy_BUILD_CORE defined within the Setup file in the case they need to use the _Py_BEGIN_SUPPRESS_IPH macro.

The Setup file is generated on figure 'configure' but it is not removed if you run "make clean".  So, if it gets generated without the Py_BUILD_CORE flags in it, you will get this mysterious build error.

Perhaps Modules/makesetup should be intelligent and add the Py_BUILD_CORE flags as needed.  One idea is to check the path of the source code (e.g. timemodule.c) and if the source is within the code interpreter folder,  add the BUILD_CORE flag.

Not sure about other platform build systems.  It looks like PCbuild does something different as it doesn't use makesetup.
History
Date User Action Args
2018-06-28 19:18:41naschemesetrecipients: + nascheme, vstinner, r.david.murray, steve.dower, Ilya.Kulakov, tnmurphy
2018-06-28 19:18:41naschemesetmessageid: <1530213521.24.0.56676864532.issue24575@psf.upfronthosting.co.za>
2018-06-28 19:18:41naschemelinkissue24575 messages
2018-06-28 19:18:41naschemecreate