➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author remi.lapeyre
Recipients ezio.melotti, kuhlmann, matrixise, pablogsal, remi.lapeyre, rhettinger
Date 2018-06-24.12:03:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1529841820.9.0.56676864532.issue33927@psf.upfronthosting.co.za>
In-reply-to
Content 
Hi Pablo, while this patch should fix both problems, I'm not sure how to write a regression test for this, `assert_python_ok` in https://github.com/python/cpython/pull/7865/files#diff-7d4645839a05727ebdf39226fd56e29cR97 forks the interpreter so I'm not sure I can check for unclosed fd during the test.

Should I call https://github.com/remilapeyre/cpython/blob/04b2ade751b318460c1f0f9566676ef519358328/Lib/json/tool.py#L18 directly and mock `io.open` and `os.close`?
History
Date User Action Args
2018-06-24 12:03:40remi.lapeyresetrecipients: + remi.lapeyre, rhettinger, ezio.melotti, matrixise, pablogsal, kuhlmann
2018-06-24 12:03:40remi.lapeyresetmessageid: <1529841820.9.0.56676864532.issue33927@psf.upfronthosting.co.za>
2018-06-24 12:03:40remi.lapeyrelinkissue33927 messages
2018-06-24 12:03:40remi.lapeyrecreate