Message320126
+ def tearDown(self):
+ self.executor.shutdown(wait=True)
+ dt = time.time() - self.t1
+ if test.support.verbose:
+ print("%.2fs" % dt, end=' ')
+ self.assertLess(dt, 60, "synchronization issue: test lasted too long")
This code has been added by:
commit aebac0b55a1e3addb93ec7992046a4f9561b4175
Author: Antoine Pitrou <solipsis@pitrou.net>
Date: Thu Mar 24 15:47:39 2011 +0100
Add tests for the atexit hook in concurrent.futures (part of #11635)
What is the purpose of having an hardcoded maximum test execution duration? If a test takes 2 seconds instead of 1, it means that the test found a design issue in concurrent.futures? Or it would mean that the test has a bug?
We have many buildbots which are super slow, so I proposed to increase the maximum duration to 5 minutes instead of 1 minute to quickly repair buildbots.
But with 5 minutes, I'm not sure that the check is still useful.
@Antoine: do you recall the rationale for this check? |
|
Date |
User |
Action |
Args |
2018-06-20 23:00:26 | vstinner | set | recipients:
+ vstinner, paul.moore, pitrou, tim.golden, zach.ware, steve.dower |
2018-06-20 23:00:25 | vstinner | set | messageid: <1529535625.99.0.56676864532.issue33716@psf.upfronthosting.co.za> |
2018-06-20 23:00:25 | vstinner | link | issue33716 messages |
2018-06-20 23:00:25 | vstinner | create | |
|