This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients paul.moore, pitrou, steve.dower, tim.golden, vstinner, zach.ware
Date 2018-06-20.23:00:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1529535625.99.0.56676864532.issue33716@psf.upfronthosting.co.za>
In-reply-to
Content
+    def tearDown(self):
+        self.executor.shutdown(wait=True)
+        dt = time.time() - self.t1
+        if test.support.verbose:
+            print("%.2fs" % dt, end=' ')
+        self.assertLess(dt, 60, "synchronization issue: test lasted too long")

This code has been added by:

commit aebac0b55a1e3addb93ec7992046a4f9561b4175
Author: Antoine Pitrou <solipsis@pitrou.net>
Date:   Thu Mar 24 15:47:39 2011 +0100

    Add tests for the atexit hook in concurrent.futures (part of #11635)


What is the purpose of having an hardcoded maximum test execution duration? If a test takes 2 seconds instead of 1, it means that the test found a design issue in concurrent.futures? Or it would mean that the test has a bug?

We have many buildbots which are super slow, so I proposed to increase the maximum duration to 5 minutes instead of 1 minute to quickly repair buildbots.

But with 5 minutes, I'm not sure that the check is still useful. 

@Antoine: do you recall the rationale for this check?
History
Date User Action Args
2018-06-20 23:00:26vstinnersetrecipients: + vstinner, paul.moore, pitrou, tim.golden, zach.ware, steve.dower
2018-06-20 23:00:25vstinnersetmessageid: <1529535625.99.0.56676864532.issue33716@psf.upfronthosting.co.za>
2018-06-20 23:00:25vstinnerlinkissue33716 messages
2018-06-20 23:00:25vstinnercreate