Author serhiy.storchaka
Recipients ned.deily, paul.moore, serhiy.storchaka, steve.dower, tim.golden, vstinner, zach.ware
Date 2018-06-02.10:52:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1527936735.61.0.592728768989.issue33720@psf.upfronthosting.co.za>
In-reply-to
Content
As for the test itself, the original test was added in dc78cc6f7cea2040114a350aa9db835cc433ae05. It tested that the stack overflow is not happen when unmarshal a fake code object with a deeply nested dict instead of co_code. It was renamed to test_loads_recursion in cf0fab2686799b562c9c6f6255557e36f9af095e. In issue16475 (d7009c69136a3809282804f460902ab42e9972f6) it was updated to mirror the changed structure of the code object in Python 3, but the original test was kept with the name test_loads_2x_code. Actually both tests work the same, because the value of few first bytes doesn't affect the result of these tests.

Yet this test is fragile, it depends on the unstable structure of the code object, and it serves its purpose only because input data checking is not very strong in the current implementation. Future changes in the marshal module can make this test invalid, and this will not be noticed.

In PR 7336 this test is rewritten in more reliable way.

This likely is not directly related to the crash.
History
Date User Action Args
2018-06-02 10:52:15serhiy.storchakasetrecipients: + serhiy.storchaka, paul.moore, vstinner, tim.golden, ned.deily, zach.ware, steve.dower
2018-06-02 10:52:15serhiy.storchakasetmessageid: <1527936735.61.0.592728768989.issue33720@psf.upfronthosting.co.za>
2018-06-02 10:52:15serhiy.storchakalinkissue33720 messages
2018-06-02 10:52:15serhiy.storchakacreate