This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author yselivanov
Recipients asvetlov, koobs, miss-islington, vstinner, yselivanov
Date 2018-05-29.15:09:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1527606583.53.0.682650639539.issue33353@psf.upfronthosting.co.za>
In-reply-to
Content
> It seems like Yury's commit 7165754b6b5f3b7c07050d921fa1c58bba5f0ff1 made sendfile tests of test_asyncio 6x slower on FreeBSD :-(

Well, yeah, I kind of expected to see a performance regression here.  Before, we were reading from a file directly, which is a blocking operation and can potentially block the event loop.  Now we're using a thread pool to do the read, but its more overhead.

In this case I think we have to do it the *correct* way, even if it means sacrificing the performance.  As a workaround, I propose to rise the read buffer size to 1Mb.
History
Date User Action Args
2018-05-29 15:09:43yselivanovsetrecipients: + yselivanov, vstinner, asvetlov, koobs, miss-islington
2018-05-29 15:09:43yselivanovsetmessageid: <1527606583.53.0.682650639539.issue33353@psf.upfronthosting.co.za>
2018-05-29 15:09:43yselivanovlinkissue33353 messages
2018-05-29 15:09:43yselivanovcreate