Message318042
> It seems like Yury's commit 7165754b6b5f3b7c07050d921fa1c58bba5f0ff1 made sendfile tests of test_asyncio 6x slower on FreeBSD :-(
Well, yeah, I kind of expected to see a performance regression here. Before, we were reading from a file directly, which is a blocking operation and can potentially block the event loop. Now we're using a thread pool to do the read, but its more overhead.
In this case I think we have to do it the *correct* way, even if it means sacrificing the performance. As a workaround, I propose to rise the read buffer size to 1Mb. |
|
Date |
User |
Action |
Args |
2018-05-29 15:09:43 | yselivanov | set | recipients:
+ yselivanov, vstinner, asvetlov, koobs, miss-islington |
2018-05-29 15:09:43 | yselivanov | set | messageid: <1527606583.53.0.682650639539.issue33353@psf.upfronthosting.co.za> |
2018-05-29 15:09:43 | yselivanov | link | issue33353 messages |
2018-05-29 15:09:43 | yselivanov | create | |
|