Author inada.naoki
Recipients Mark.Shannon, benjamin.peterson, eitan.adler, flherne, georg.brandl, inada.naoki, lukasz.langa, mbussonn, minrk, ncoghlan, ned.deily, rhettinger, serhiy.storchaka, vstinner
Date 2018-05-25.17:10:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1527268257.29.0.682650639539.issue32911@psf.upfronthosting.co.za>
In-reply-to
Content
> B. Revert the feature now for 3.7.0, retargeting for 3.8, and produce a 3.7.0b5 on a somewhat shorter cycle to allow downstream users to adapt to the removal.

Please note that it can't be reverted simply.
The change was introduced to ease AST-layer optimization (`"abc" + "def"` is not docstring, but `"abcdef"` is docstring.)
And we implemented some AST-layer optimization already.

There are two ways to revert the change:

B1. Just remove `.docstring` attribute and implement hack to distinguish string and docstring in some places.

B2. Remove `.docstring` attribute, but introduce `DocString` statement.  This was my patch (PR-5927)

In case of B2, thirdparty libraries should follow the change anyway.
In case of IPython, `DocString(s="spam")` may be replaced with `Expr(Str(s="spam"))`

In case of B1, I hadn't tried it yet and I don't know how difficult it is.  I'll try but I can't say estimated time for now.
History
Date User Action Args
2018-05-25 17:10:57inada.naokisetrecipients: + inada.naoki, georg.brandl, rhettinger, ncoghlan, vstinner, benjamin.peterson, ned.deily, lukasz.langa, Mark.Shannon, serhiy.storchaka, eitan.adler, minrk, mbussonn, flherne
2018-05-25 17:10:57inada.naokisetmessageid: <1527268257.29.0.682650639539.issue32911@psf.upfronthosting.co.za>
2018-05-25 17:10:57inada.naokilinkissue32911 messages
2018-05-25 17:10:57inada.naokicreate