Author serhiy.storchaka
Recipients inada.naoki, remi.lapeyre, rhettinger, selik, serhiy.storchaka
Date 2018-05-24.11:42:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1527162150.2.0.682650639539.issue33462@psf.upfronthosting.co.za>
In-reply-to
Content
I concur with Inada. It is a "nice to have" feature, but it has too high cost. PR 6827 adds around 300 lines of new code in dictobject.c. Too large for rarely used feature. And dictobject.c is critically important, adding new code here can make the compiler generating less optimal code for other parts. That is besides increasing the maintenance cost.

I may have a case for iterating dict in the reversed order (see issue33331), but adding three new types requires adding too much boilerplate code. In the current form PR 6827 can't be merged, and I don't see a way how to make the code much shorter without impact on the current code. :-(
History
Date User Action Args
2018-05-24 11:42:30serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, inada.naoki, selik, remi.lapeyre
2018-05-24 11:42:30serhiy.storchakasetmessageid: <1527162150.2.0.682650639539.issue33462@psf.upfronthosting.co.za>
2018-05-24 11:42:30serhiy.storchakalinkissue33462 messages
2018-05-24 11:42:30serhiy.storchakacreate