Author cheryl.sabella
Recipients cheryl.sabella, terry.reedy
Date 2018-05-23.23:48:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1527119313.11.0.682650639539.issue33628@psf.upfronthosting.co.za>
In-reply-to
Content
Based on the github comments on PR5638, some code cleanup issues identified for codecontext.

codecontext
* getspacesfirstword - function and param1 name
* get_line_info - make into helper function and change parm
* get_context - call to get_line_info sends text instead of line number
* toggle_code_context_event - move border calc to same loop at padx
* cleanup some comments

test_codecontext
* test_get_line_info - move test to helper test class and change parm from line number to line
* test_get_line_info - add test for tab (I noticed 'indent' is 1 when the regex matches to a tab.  Even though IDLE doesn't allow tabs in the editor, I didn't want to lose track of this).
* test_getspacesfirstword - function name
* test_del - remove call to after info
History
Date User Action Args
2018-05-23 23:48:33cheryl.sabellasetrecipients: + cheryl.sabella, terry.reedy
2018-05-23 23:48:33cheryl.sabellasetmessageid: <1527119313.11.0.682650639539.issue33628@psf.upfronthosting.co.za>
2018-05-23 23:48:33cheryl.sabellalinkissue33628 messages
2018-05-23 23:48:33cheryl.sabellacreate