Author eitan.adler
Recipients GooseYArd, Jason.Grout, eitan.adler, jdemeyer, serhiy.storchaka, tarek, vokoda, zooko
Date 2018-05-15.21:37:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1526420235.13.0.682650639539.issue5755@psf.upfronthosting.co.za>
In-reply-to
Content
copying and adapting my comments on the PR:

Strict Prototypes is correct and helpful for C. That said, the way it is currently implemented, by checking for the compiler in CC is sub-optimal at best.
CC ought to always be a C compiler, and never a C++ compiler.
It also seems questionable that distutils is using the python cflags rather than a dedicated set.

The best fix is a separate and specific list of flags for distutils rather than modifying the set of flags used to build python. That said, the current implementing of flags for python isn't great, so lets remove it as a short term fix.
History
Date User Action Args
2018-05-15 21:37:15eitan.adlersetrecipients: + eitan.adler, zooko, tarek, Jason.Grout, GooseYArd, vokoda, serhiy.storchaka, jdemeyer
2018-05-15 21:37:15eitan.adlersetmessageid: <1526420235.13.0.682650639539.issue5755@psf.upfronthosting.co.za>
2018-05-15 21:37:15eitan.adlerlinkissue5755 messages
2018-05-15 21:37:15eitan.adlercreate