Author serhiy.storchaka
Recipients brett.cannon, eric.snow, ncoghlan, pitrou, serhiy.storchaka, vstinner
Date 2018-04-22.08:56:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1524387390.7.0.682650639539.issue33330@psf.upfronthosting.co.za>
In-reply-to
Content
The proposed PR adds missed checks for errors and PyErr_Clear() calls in PyImport_Cleanup().

It may be worth to use PyErr_WriteUnraisable() in place of PyErr_Clear() (newly added and existing) in most cases. But this can add an unexpected noise, and I don't wont to do this at this stage of 3.7. It could be done in 3.8 though, and backported to 3.7 later.

I'm not sure that PyImport_Cleanup() works properly if sys.modules is not a dict. At this stage a custom mapping will likely be broken when most of modules are destroyed.
History
Date User Action Args
2018-04-22 08:56:30serhiy.storchakasetrecipients: + serhiy.storchaka, brett.cannon, ncoghlan, pitrou, vstinner, eric.snow
2018-04-22 08:56:30serhiy.storchakasetmessageid: <1524387390.7.0.682650639539.issue33330@psf.upfronthosting.co.za>
2018-04-22 08:56:30serhiy.storchakalinkissue33330 messages
2018-04-22 08:56:30serhiy.storchakacreate