Author rhettinger
Recipients benjamin.peterson, brett.cannon, methane, ncoghlan, pitrou, rhettinger, serhiy.storchaka, yselivanov
Date 2018-04-20.19:45:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1524253508.81.0.682650639539.issue33318@psf.upfronthosting.co.za>
In-reply-to
Content
+0 It looks like there is a small net win.  Conceptually, constant folding is better done upstream where more semantic information is available (rather than downstream when the meaning has to be deduced from the opcodes).  The only drawback is that if unfolded tuples ever leak out of the AST step or get created by the peephole optimization step, then they won't get fixed-up downstream (as functionality gets moved out of peephole.c, it creates more obligations on the AST code generation step to always produce the best possible code because the finally neatening-up step no longer occurs).
History
Date User Action Args
2018-04-20 19:45:08rhettingersetrecipients: + rhettinger, brett.cannon, ncoghlan, pitrou, benjamin.peterson, methane, serhiy.storchaka, yselivanov
2018-04-20 19:45:08rhettingersetmessageid: <1524253508.81.0.682650639539.issue33318@psf.upfronthosting.co.za>
2018-04-20 19:45:08rhettingerlinkissue33318 messages
2018-04-20 19:45:08rhettingercreate