Author benjamin.peterson
Recipients benjamin.peterson, fweimer, gregory.p.smith, methane, twouters
Date 2018-04-19.16:18:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1524154689.88.0.682650639539.issue33312@psf.upfronthosting.co.za>
In-reply-to
Content
Your PR is basically what we did prior to 186122ead26f3ae4c2bc9f6715d2a29d339fdc5a. The problem is that may run afoul of different UB, namely strict aliasing. (Though, I suppose we could probably also avoid that by making dk_indices char[].)

If VLAs work with whatever MSVC we're using, it seems fine to add it to PEP 7. At worst, we can #ifdef sanitizer it.
History
Date User Action Args
2018-04-19 16:18:09benjamin.petersonsetrecipients: + benjamin.peterson, twouters, gregory.p.smith, methane, fweimer
2018-04-19 16:18:09benjamin.petersonsetmessageid: <1524154689.88.0.682650639539.issue33312@psf.upfronthosting.co.za>
2018-04-19 16:18:09benjamin.petersonlinkissue33312 messages
2018-04-19 16:18:09benjamin.petersoncreate