Message315491
Your PR is basically what we did prior to 186122ead26f3ae4c2bc9f6715d2a29d339fdc5a. The problem is that may run afoul of different UB, namely strict aliasing. (Though, I suppose we could probably also avoid that by making dk_indices char[].)
If VLAs work with whatever MSVC we're using, it seems fine to add it to PEP 7. At worst, we can #ifdef sanitizer it. |
|
Date |
User |
Action |
Args |
2018-04-19 16:18:09 | benjamin.peterson | set | recipients:
+ benjamin.peterson, twouters, gregory.p.smith, methane, fweimer |
2018-04-19 16:18:09 | benjamin.peterson | set | messageid: <1524154689.88.0.682650639539.issue33312@psf.upfronthosting.co.za> |
2018-04-19 16:18:09 | benjamin.peterson | link | issue33312 messages |
2018-04-19 16:18:09 | benjamin.peterson | create | |
|