Message314726
> If we're going to call new_class in make_dataclass, then we should change the signature of make_dataclass to have the new_class parameters.
Why? I think we should care about what API/signature is reasonable/typical for dataclasses use cases, while new_class is really just an implementation detail. IMO passing keyword arguments to metaclass will be much more rare for dataclasses than passing a ready namespace. |
|
Date |
User |
Action |
Args |
2018-03-30 22:51:39 | levkivskyi | set | recipients:
+ levkivskyi, eric.smith, Ricyteach |
2018-03-30 22:51:39 | levkivskyi | set | messageid: <1522450299.21.0.467229070634.issue33188@psf.upfronthosting.co.za> |
2018-03-30 22:51:39 | levkivskyi | link | issue33188 messages |
2018-03-30 22:51:39 | levkivskyi | create | |
|