Author agnosticdev
Recipients agnosticdev, bbayles, berker.peksag, eric.smith, jonathan-lp
Date 2018-03-16.01:56:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1521165365.28.0.467229070634.issue33034@psf.upfronthosting.co.za>
In-reply-to
Content
"Wouldn't we be better off to catch this error at parse time, instead of just improve the error message when .port is called?"

I think there could be a case to be made about catching and dealing with this error in urlparse() / urlsplit() instead of displaying an error when port property is used.  I think that approaching it this way would cut right to the problem and alleviate carrying around a potentially bad port value.  However, if the port error was caught during parsing but the url, scheme, etc.. values were still valid, are we taking away something from the user by raising the error too soon?  Just a thought.
History
Date User Action Args
2018-03-16 01:56:05agnosticdevsetrecipients: + agnosticdev, eric.smith, berker.peksag, bbayles, jonathan-lp
2018-03-16 01:56:05agnosticdevsetmessageid: <1521165365.28.0.467229070634.issue33034@psf.upfronthosting.co.za>
2018-03-16 01:56:05agnosticdevlinkissue33034 messages
2018-03-16 01:56:04agnosticdevcreate