This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lukasz.langa
Recipients amogorkon, cheryl.sabella, eryksun, ethan.furman, lukasz.langa, ncoghlan, rhettinger, xiang.zhang
Date 2018-03-14.22:23:48
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1521066228.25.0.467229070634.issue27984@psf.upfronthosting.co.za>
In-reply-to
Content
I'm sorry that you wasted your time on those pull requests, Xiang but:
- we cannot accept any new features for 3.6 and 3.7 anymore;
- the problem described in this issue is fixed, as you noticed yourself, by #32227.

The wrapper returned by the `@register` decorator is calling `dispatch()` with the first argument's `__class__`. It can only ever be invalid if somebody deliberately wrote something invalid to the object's `__class__`. It's extremely unlikely.

We should not slow down *calling* of all generic functions on the basis that somebody might pass a non-type straigh to `dispatch()`.

Cheryl, thanks for your help triaging the bug tracker! It might be a good idea to confirm with people on old issues whether moving the patch to a pull request is indeed the missing part of it getting merged. In this case it wasn't, I hope Xiang won't feel bad about me rejecting his pull requests after you pinged him for them.
History
Date User Action Args
2018-03-14 22:23:48lukasz.langasetrecipients: + lukasz.langa, rhettinger, ncoghlan, ethan.furman, eryksun, xiang.zhang, amogorkon, cheryl.sabella
2018-03-14 22:23:48lukasz.langasetmessageid: <1521066228.25.0.467229070634.issue27984@psf.upfronthosting.co.za>
2018-03-14 22:23:48lukasz.langalinkissue27984 messages
2018-03-14 22:23:48lukasz.langacreate