Author gregory.p.smith
Recipients Decorater, Sworddragon, alanmcintyre, bbayles, berker.peksag, fberger, gregory.p.smith, jens, jfoo, serhiy.storchaka
Date 2018-02-26.21:36:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1519680966.45.0.467229070634.issue21417@psf.upfronthosting.co.za>
In-reply-to
Content
keeping the conversation in one place, the code review comment was: "I've prefixed this with an underscore because it's not exposed when reading back. ZipInfo has another "private" attribute, _raw_time"

compresslevel is documented on the public APIs where it appears, I do not believe it needs to be a public attribute within ZipInfo given the above as that is an implementation detail.  If we ever find a good reason to make it public in the future we can add a property.
History
Date User Action Args
2018-02-26 21:36:06gregory.p.smithsetrecipients: + gregory.p.smith, alanmcintyre, Sworddragon, fberger, berker.peksag, jens, serhiy.storchaka, jfoo, Decorater, bbayles
2018-02-26 21:36:06gregory.p.smithsetmessageid: <1519680966.45.0.467229070634.issue21417@psf.upfronthosting.co.za>
2018-02-26 21:36:06gregory.p.smithlinkissue21417 messages
2018-02-26 21:36:06gregory.p.smithcreate