This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author terry.reedy
Recipients cheryl.sabella, terry.reedy
Date 2018-02-20.04:16:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1519100182.71.0.467229070634.issue32880@psf.upfronthosting.co.za>
In-reply-to
Content
set_str sets self.str and self.study_level.  After the first call, attempts to access unset instance parse attributes from other modules will raise AttributeError.  Removing the unneeded class setting will just add 2 more names to the list of things that should not be called directly.  The get_xyz functions (get_continuation_type is another) avoid AttributeError (unless self.str is not set) and ensure validity.

If set_str is called more than once, instance parse attributes will initially be set but invalid.  So it seems they should be either deleted or set to None.  In the latter case, they should also be set to None initially.  I will look more at how the module is used.
History
Date User Action Args
2018-02-20 04:16:22terry.reedysetrecipients: + terry.reedy, cheryl.sabella
2018-02-20 04:16:22terry.reedysetmessageid: <1519100182.71.0.467229070634.issue32880@psf.upfronthosting.co.za>
2018-02-20 04:16:22terry.reedylinkissue32880 messages
2018-02-20 04:16:22terry.reedycreate