Author Ma Lin
Recipients Ma Lin, ned.deily, paul.moore, skn78, steve.dower, thatiparthy, tim.golden, tjguk, zach.ware
Date 2018-02-02.09:47:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1517564841.38.0.467229070634.issue32394@psf.upfronthosting.co.za>
In-reply-to
Content
Glad to see PR 5468 not merged, I found it makes socket.py complicated.

Now I'm inclined to patch the code in PyInit__socket(void) of socketmodule.c
https://github.com/python/cpython/blob/3.6/Modules/socketmodule.c#L6504

There already has a MS-Windows version checking
https://github.com/python/cpython/blob/3.6/Modules/socketmodule.c#L6511

In there, we can use GetVersionEx instead of GetVersion to get BuildNumber, then delete unusable opinions.

(I don't have enough skill to modify .c code)
History
Date User Action Args
2018-02-02 09:47:21Ma Linsetrecipients: + Ma Lin, paul.moore, tim.golden, ned.deily, zach.ware, steve.dower, thatiparthy, tjguk, skn78
2018-02-02 09:47:21Ma Linsetmessageid: <1517564841.38.0.467229070634.issue32394@psf.upfronthosting.co.za>
2018-02-02 09:47:21Ma Linlinkissue32394 messages
2018-02-02 09:47:21Ma Lincreate